search

cruizba / ubuntu-dind

A docker image based in ubuntu to run docker containers inside docker containers
Apache License 2.0
180 stars 83 forks source link

Update docker-compose #9

Closed svanharmelen closed 1 year ago

svanharmelen commented 1 year ago

Hi @cruizba! We stubled upon this repo and it solved a problem we had. So thank you for making and sharing this repo!

Yet we do have one little thingy which requires us to fork the repo, and that is that we need this for arm64. This should all work fine, except that docker-compose doesn't have prebuild releases for arm64 for their 1.x versions.

So is it possible to switch to a 2.x version for compose? Or would it be possible to make it configurable? If not, we'll just keep using our fork, but I generally prefer to try and "fix" (of course it's not really broken atm) things upstream whenever possible 😊

cruizba commented 1 year ago

Hi @svanharmelen , I do not have too much time right now but, if you want to create a PR with the new docker compose version, I would merge without any problem :)

svanharmelen commented 1 year ago

Thanks @cruizba! Created PR #10 to update to the latest docker-compose 👍🏻

cruizba commented 1 year ago

I'll take a look this weekend. Is it possible to install docker-compose as a binary? I thought it was a plugin of docker.

Now I am asking myself if someone may want to execute docker compose instead of docker-compose :thinking:

svanharmelen commented 1 year ago

Not sure... We don't even use docker-compose at all, but we need this change so we can build the container for arm64 😅

svanharmelen commented 1 year ago

Any updates/thoughts on this one?

cruizba commented 1 year ago

Done, I've added a symlink to docker compose plugins, so the command docker compose and docker-compose can be used.

https://github.com/cruizba/ubuntu-dind/commit/720ed822b9c27ada883272668ee38ba0eb70718e

svanharmelen commented 1 year ago

Super nice, thanks!