Adding a possibility to ignore directories

crumbhole / argocd-lovely-plugin

A plugin to make Argo CD behave like we'd like.

BSD 3-Clause "New" or "Revised" License

357 stars 22 forks source link

Adding a possibility to ignore directories #431

Open valibali opened 4 months ago

valibali commented 4 months ago

Usecase: Sometimes (especially when using ApplicationSets) in overlay directories (non-Kubernetes manifest-)YAML files are used. However they are picked up by the YAMLProcessor() as they were Kubernetes manifesters.

So can we either:

Ignore an arbitrary path (given in ENVVAR?)?
Turn on/off processors?

(deleting them with a pre-processor looked super-ugly)

Joibel commented 4 months ago

Of the options you've presented I'd prefer the "ignore path" option as a new parameter. Something like lovely_ignore_subpath, taking a space separated list of paths to ignore if they exist.

You could then set this globally as an environment variable if you wanted to.

Would you be interested in contributing this?

valibali commented 4 months ago

Absolutely!

Joibel commented 4 months ago

Awesome.

A bit of guidance then:

Add the new parameter to pkg/features/features.go
Check on the directory in cmd/argocd-lovely-plugin/packageDirectories.go to exclude it.
Make sure you make generate before submitting a PR

Ensure you document it in features.go as just being for ignoring 'sub applications' as that's all it'll do.

valibali commented 4 months ago

https://github.com/crumbhole/argocd-lovely-plugin/pull/432