search

crumbhole / argocd-lovely-plugin

A plugin to make Argo CD behave like we'd like.
BSD 3-Clause "New" or "Revised" License
392 stars 26 forks source link

feature request: support helmfile/vals as a plugin in container #611

Open LPLabrys99 opened 2 hours ago

LPLabrys99 commented 2 hours ago

Hi, I've been using the argocd lovely plugin for a little while now and I think it's really great. There is one thing that I think could be better - it would be nice if the container supported the helmfile/vals project by default. https://github.com/helmfile/vals

Vals is a secrets connector that supports various backends out of the box. As a kubernetes operator you can specify references to secrets in your values files with a format like ref+gcp://.... and vals will look up the secret when templating the charts. It comes built into helmfile but can also be run as a standalone app. Helmfile comes with vals built-in to its own binary but there doesn't seem to be a way to invoke vals through helmfile. If you want to use vals by itself you have to install it as a standalone app.

As a user of argocd/lovely plugin, if I am deploying a single simple Helm chart with some secrets and don't want to set up another helmfile in the repo it would be ideal to use argocd + lovely plugin with standard helm + vals in the pipeline.

Joibel commented 2 hours ago

It looks like this would be achievable with a lovely variation

Would you like to contribute a PR for this?

LPLabrys99 commented 1 hour ago

I don't have experience in golang but I'm willing to try.

By the way, given that lovely supports pipeline customisation, is there a reason why vals shouldn't be included in all variations as helmfile is currently?