search

crunchy-labs / crunchy-cli

👇 Command-line downloader for Crunchyroll
MIT License
607 stars 63 forks source link

add minimum subtitle size #321

Closed kralverde closed 10 months ago

kralverde commented 10 months ago

Dubbed videos have subtitles but they often have no useful information and can clutter download files. This PR adds a parameter to set a minimum meaningful subtitle file size (defaulting to 0, though I've found 4K works well even for short videos).

bytedream commented 10 months ago

Do you have an example of non-CC subtitles which "aren't useful"?

kralverde commented 10 months ago

That's a good point, I didn't really think of that. They have all been CC's. I see the logic for ignoring (?) CC's in archive/command.rs, though I have still been getting them in my archives (maybe because with audio merging there is more than one subtitle per stream?). I suppose a cleaner solution should exist there.

bytedream commented 10 months ago

There currently is no logic to ignore CC's but I like the idea to do so, at least for archive. You can re-open this PR or open a new one if you want to implement it