crunchy-labs / crunchy-cli

👇 Command-line downloader for Crunchyroll
MIT License
606 stars 62 forks source link

Failing to generate output file #337

Closed RBin789 closed 8 months ago

RBin789 commented 9 months ago

Describe the bug When I try to download the season everything works fine it downloads both videos with there respective audio files and the subtitle file then as soon as it starts "Generating output file" it crashs with :

thread 'tokio-runtime-worker' panicked at D:\a\crunchy-cli\crunchy-cli\crunchy-cli-core\src\utils\download.rs:1199:22:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
:: An error occurred: task 1252 panicked

To Reproduce Just run the command below

archive -a en-US -a zh-CN -s en-US --ffmpeg-preset h264 --speed-limit 2MB -o "{series_name} - S{season_number}E{episode_number} - {title}.mkv" https://www.crunchyroll.com/series/GZJH3DJ8E/the-daily-life-of-the-immortal-king[S2]

Expected behavior It should download every episode of The Daily Life of the Immortal King Season 2 with English and Mandarin audio and English Subtitles. with files in the form "The Daily Life of the Immortal King - S02E# - Episode Name"

Client:

Additional context Downloading has worked for while but yesterday while downloading (The Daily Life of the Immortal King) my computer shutdown unexpectedly, I think something tried to use Hyper-V-Hypervisor when virtualization was disabled so my computer shutdown anyway after that i went into my BIOS and re enabled virtualization. Now it gives the error i described above when i try to download it again. Is crunchy-cli sensitive to virtualization i don't want to disable it just to use crunchy-cli.

bytedream commented 9 months ago

Hey thanks for your issue report. crunchy-cli does nothing with virtualization so this shouldn't be a blocker. The error occurs because crunchy-cli asserts that ffmpeg writes its progress in a specific format to a file but in your case there seems to be some sort of issue with the progress output ffmpeg reports.

A fix for such issues will land in the next release

RBin789 commented 9 months ago

Thanks for the response in the meantime is there anything i can do to stop the bug?

bytedream commented 9 months ago

You can use the pre-built windows binary from here (scroll down and download the crunchy-cli-windows-x86_64 file). It contains the fix

bytedream commented 8 months ago

The fix is now available in v3.3.0