search

crunchy-labs / crunchy-cli

👇 Command-line downloader for Crunchyroll
MIT License
606 stars 62 forks source link

The subtitles obtained are underlined and crossed out #402

Closed jeluchu closed 6 months ago

jeluchu commented 6 months ago

Describe the bug When downloading an episode, the subtitles that are downloaded along with the episode are crossed out and underlined.

To Reproduce Execute the command that I have indicated in the issue, and open a video player once downloaded activating the subtitles (in this case I put the Spanish ones), I have tried with a macOS player (Elmedia Player) and also with VLC and I get the same result, crossed out and underlined subtitles.

crunchy-cli archive --language-tagging ietf --include-chapters -m audio -a ja-JP -s es-ES https://www.crunchyroll.com/es/watch/GPWUK9KD8/in-the-nick-of-time-a-big-time-maverick-from-the-west

Expected behavior The result would be subtitles without strikethrough and underlining.

Screenshots Captura de pantalla 2024-05-06 a las 13 12 20

Client (please complete the following information):

bytedream commented 6 months ago

This a bug in the subtitle library that was newly introduced (https://github.com/crunchy-labs/crunchy-cli/discussions/401#discussioncomment-9319617). I already created a patch and only waiting for it to get merged. Until the patch is available, use v3.5.2

jeluchu commented 6 months ago

Perfect! Thank you very much for the quick response and for your work! ✨

bytedream commented 6 months ago

The fix is now available in v3.6.1