search

crunchy-labs / crunchy-cli

👇 Command-line downloader for Crunchyroll
MIT License
606 stars 62 forks source link

Linux: Anime title not being sanitized #420

Closed ToMattBan closed 6 months ago

ToMattBan commented 6 months ago

Describe the bug So, with the newers versions, crunchy-cli fails to download some anime, since it tries to create the title with some characteres like : and ?

To Reproduce Steps / command to reproduce the behavior:

$ crunchy-cli --lang pt-BR archive -a ja-JP -a pt-BR -s pt-BR -m audio -o "./Slime/{season_number} {episode_number} {title}.mkv"  https://www.crunchyroll.com/pt-br/series/GYZJ43JMR/[S2]

This command gaves me this output:

That Time I Got Reincarnated as a Slime Season 2 (That Time I Got Reincarnated as a Slime Season 2)
::      1. Divagação: Hinata Sakaguchi » S02E24.9
::      2. A vida ocupada de Rimuru » S02E25
::      3. Comércio com o Reino Animal » S02E26
::      4. Paraíso, mais uma vez » S02E27
::
::      THERE WAS ALL EPISODES HERE, BUT I REMOVED TO KEEP THE ISSUE SMALLER    
::
:: Downloading Divagação: Hinata Sakaguchi to '/media/serverzin/Midia/Mídia/_Novos/Animes/Slime/02 24.9 Divagação: Hinata Sakaguchi.mkv'
::      Episode: S02E24.9
::      Audio: ja-JP, pt-BR
::      Subtitles: pt-BR
::      Resolution: 1920x1080
::      FPS: 23.97
:: Downloading ja-JP audio  22.22 MiB 651.57 KiB/s [###############################################################################] 100%
:: Downloading pt-BR audio  22.22 MiB  11.03 MiB/s [###############################################################################] 100%
:: Downloading video #1      1.32 GiB  23.11 MiB/s [###############################################################################] 100%
:: Downloading subtitles    pt-BR (CC), pt-BR                                                                                            
:: Generating output file   [------------------------------------------------------------------------------------------------------]   0%
:: An error occurred: Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/tmp/.crunchy-cli_Y6lYuJ.mp4':
  Metadata:
    major_brand     : iso5
    minor_version   : 1
    compatible_brands: iso5dashmsix
  Duration: 00:23:42.01, start: 0.000000, bitrate: 7972 kb/s
  Stream #0:0[0x1](eng): Video: h264 (High) (avc1 / 0x31637661), yuv420p(progressive), 1920x1080 [SAR 1:1 DAR 16:9], 7939 kb/s, 23.98 fps, 23.98 tbr, 90k tbn (default)
    Metadata:
      handler_name    : VideoHandler
      vendor_id       : [0][0][0][0]
Input #1, mov,mp4,m4a,3gp,3g2,mj2, from '/tmp/.crunchy-cli_Wlns4j.m4a':
  Metadata:
    major_brand     : iso5
    minor_version   : 1
    compatible_brands: iso5dashmsix
  Duration: 00:23:42.06, start: 0.000000, bitrate: 131 kb/s
  Stream #1:0[0x1](eng): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 127 kb/s (default)
    Metadata:
      handler_name    : SoundHandler
      vendor_id       : [0][0][0][0]
Input #2, mov,mp4,m4a,3gp,3g2,mj2, from '/tmp/.crunchy-cli_LF08bJ.m4a':
  Metadata:
    major_brand     : iso5
    minor_version   : 1
    compatible_brands: iso5dashmsix
  Duration: 00:23:42.11, start: 0.000000, bitrate: 131 kb/s
  Stream #2:0[0x1](eng): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 127 kb/s (default)
    Metadata:
      handler_name    : SoundHandler
      vendor_id       : [0][0][0][0]
Input #3, ass, from '/tmp/.crunchy-cli_F0OaVr.ass':
  Duration: N/A, bitrate: N/A
  Stream #3:0: Subtitle: ass
Input #4, ass, from '/tmp/.crunchy-cli_0Weuxi.ass':
  Duration: N/A, bitrate: N/A
  Stream #4:0: Subtitle: ass
/Slime/02 24.9 Divagação: Hinata Sakaguchi.mkv: Invalid argument

Expected behavior To download the episode without any problem. I'm sure it's the : after "Divagação" since if I try to download passing another name instead {title} it downloads, and it just fails in this ep (And others that also have special characteres)

Client (please complete the following information):

Frooastside commented 6 months ago

You can try and add the --universal-output flag to your command

ToMattBan commented 6 months ago

WOW, this answer was fast XD And yeah, it fixed, thanks!

bytedream commented 6 months ago

Which linux distro (and version if it has any) are you running @ToMattBan? When I try to download it (Arch), ffmpeg works fine with the colon

ToMattBan commented 6 months ago

@bytedream I'm running a debian 12 It is strange, before all that fuzz about the DRM, it wasn't a problem. It started with the past versions