crunchy-labs / crunchy-cli

👇 Command-line downloader for Crunchyroll
MIT License
608 stars 61 forks source link

[Bug] (-l all -m audio) adding the English Dub when it isn't matching #51

Closed ErezZM closed 2 years ago

ErezZM commented 2 years ago

-m audio - adds only English Dubs even when it isn't match. Others are ignored, only English always added.

I've tried using this command: app.exe archive --resolution best -l all -m audio --directory "Season {season_number}" --output "{series_name} [S{season_number}E{episode_number}] - {title} - [{resolution}][{audio}][{subtitle}].mkv" %stream%

and tried on Classroom of the Elite. https://beta.crunchyroll.com/series/GRVN8MNQY

ErezZM commented 2 years ago

It adds all of the matching ones, and English, which isn't match.

bytedream commented 2 years ago

What exactly are you trying to do?

ErezZM commented 2 years ago

I'm trying to make a video with multiple dubs. When i'm choosing to merge the audio, It says which dubs accurite to the jp video, And merge them together. The only problem is that it isn't detect that the English dub has different video, and it isn't accurate to the jp video source.

bytedream commented 2 years ago

You have to remove the -m audio flag. It forces crunchy-cli to download just a single video (in this case, the japanese) and for all other dubs, store only their audio. You have to remove it if you want matching english video and dubs. There is also a tiny wiki section about this issue (down at Archive, before the flag table).

ErezZM commented 2 years ago

Oh, okay. So it doesn't check if dubs is the same length as the jp-video?

And i have another request, can you add an option to download and mux fonts? Because when, for example, you are download an Arabic Subtitles, it uses a font that Crunchyroll sends to the client.