search

crunzphp / crunz

A PHP-based job scheduler
MIT License
176 stars 16 forks source link

Getter for 'from' and 'to' event's configuration #60

Closed lucatacconi closed 10 months ago

lucatacconi commented 11 months ago
Q A
Fixed issue #59

Inside the Event class there are several methods that allow you to have details on the individual task such as getId(), getSummaryForDisplay(), getExpression(), etc..

However, by setting the task lifetime with the beetween(), from() or to() methods there is no way to read this configuration from the class.

I added two protected variables that allow saving the from and to information, which will only be used for displaying the information and will not influence the behavior of the Event class in any way. I then added the two methods getFrom() and getTo() to display the information.

lucatacconi commented 11 months ago

I think i fixed php-cs-fixer shown issues

lucatacconi commented 11 months ago

Yippee, all green lights in code testing..

lucatacconi commented 11 months ago

Pablo where are you? I don't want to be pushy but I would like to understand if you consider the change useless or that it requires further changes or if it is just a question of time available for you to evaluate the code.

PabloKowalczyk commented 10 months ago

Pablo where are you? I don't want to be pushy but I would like to understand if you consider the change useless or that it requires further changes or if it is just a question of time available for you to evaluate the code.

I'm here :) I need to do some maintenance work on Crunz, then You could rebase your PR and I will review it, but automatic tests is a must.

lucatacconi commented 10 months ago

Sure no problem. I will prepare another pull request on the new released version. The last time the tests were successful and moreover the modified code was very little. The request will arrive as soon as you make it.

PabloKowalczyk commented 10 months ago

You can start with new PR, just remember to target 3.6 branch.