search

crunzphp / crunz

A PHP-based job scheduler
MIT License
176 stars 16 forks source link

Getter for 'from', 'to' event's configuration #68

Closed lucatacconi closed 10 months ago

lucatacconi commented 10 months ago
Q A
Fixed issue #59

Inside the Event class there are several methods that allow you to have details on the individual task such as getId(), getSummaryForDisplay(), getExpression(), etc..

However, by setting the task lifetime with the beetween(), from() or to() methods there is no way to read this configuration from the class.

I added two protected variables that allow saving the from and to information, which will only be used for displaying the information and will not influence the behavior of the Event class in any way. I then added the two methods getFrom() and getTo() to display the information.

PabloKowalczyk commented 10 months ago

CI reported some issues https://github.com/crunzphp/crunz/actions/runs/6561933443/job/17861565426?pr=68

lucatacconi commented 10 months ago

All jobs done

lucatacconi commented 10 months ago

Are there any other changes you think are needed?

PabloKowalczyk commented 10 months ago

Thanks @lucatacconi