crusj / bookmarks.nvim

Remember file locations and sort by time and frequency and support telescope.
MIT License
222 stars 17 forks source link

Feature request: Replace virt_pattern by disabled file types #24

Closed MariaSolOs closed 1 year ago

MariaSolOs commented 1 year ago

From my use of other plugins, I find it more intuitive to indicate which file types I don't want the virtual mark to be enabled in, rather than having to list all the extensions I want the virtual mark to appear in.

crusj commented 1 year ago

From my use of other plugins, I find it more intuitive to indicate which file types I don't want the virtual mark to be enabled in, rather than having to list all the extensions I want the virtual mark to appear in.

If it did, it would be a completely opposite change, I would consider it.

MariaSolOs commented 1 year ago

@crusj maybe you could add an opposite setting and require at most one to be defined. That is, have an ignore_virt_pattern setting which cannot be defined at the same time as virt_pattern.

crusj commented 1 year ago

The issue will be closed.

sshelll commented 9 months ago

43 @MariaSolOs @crusj Hi guys~ I've done this feature in this PR, this works on my local env~