crust-firmware / crust

SCP (power management) firmware for sunxi SoCs
Other
154 stars 34 forks source link

build: Drop implicit-fallthrough to allow older build compilers #181

Closed Andre-ARM closed 3 years ago

Andre-ARM commented 3 years ago

-Wimplicit-fallthrough was introduced in GCC 7, so currently building crust requires all three involved compilers to be at least of that vintage.

While it's somewhat feasible to upgrade to a newer cross-compiler, the system compiler is much harder to update on its own, especially in long term stable distributions.

To allow building crust on older Linux systems without extended surgery, drop the new warning option from the "build" compiler flavour. Actually it is explicitly disabled again when building Kconfig, so we don't really lose anything.

Signed-off-by: Andre Przywara andre.przywara@arm.com

Purpose

Closes #

Considerations for reviewers

smaeul commented 3 years ago

Thanks! Applied as 8dae7bfccc4a7792137478669023b6cf5332e8da