search

crust-firmware / crust

SCP (power management) firmware for sunxi SoCs
Other
150 stars 34 forks source link

NanoPi A64 support #193

Closed sergey-suloev closed 2 years ago

sergey-suloev commented 2 years ago

Should NanoPi A64 be supported by a separate config or defconfig should be used ?

smaeul commented 2 years ago

From the NanoPi A64 schematic, the board looks to have the usual AXP803 PMIC and regulator setup, and it also has an infrared receiver. So this would be a good config to start with:

CONFIG_CIR=y
CONFIG_MFD_AXP20X=y

(which happens to be the same as orangepi_win_defconfig).

Let me know if this works for you, and I will add it as nanopi_a64_defconfig. Or you can send a pull request if you prefer.

sergey-suloev commented 2 years ago

@smaeul in this case I can use pine64_plus_defconfig, correct ?

smaeul commented 2 years ago

I prefer each board to have its own config file, even if there end up being several identical files. That way if the config does need to change in the future, there is no worry about how it affects some other board.

smaeul commented 2 years ago

Implemented in #194 (merged as a194bdb192281baa3347a32aa6e45b9082517b4f).