crust-firmware / crust

SCP (power management) firmware for sunxi SoCs
Other
150 stars 34 forks source link

Adds configuration for NanoPi A64 board #194

Closed sergey-suloev closed 2 years ago

sergey-suloev commented 2 years ago

Purpose

Considerations for reviewers

Closes #

smaeul commented 2 years ago

Thanks for sending this. I assume you tried using the firmware and it works? It would be good to include in the commit message what you tested: if you tried suspend/resume, power button, IR remote, RTC wake, etc.

Also, please update your commit author/message, per the contribution guidelines:

All contributions to this project must be released under the open-source license used by the project. To help ensure this, all commits you make must be accompanied by your real name and a Signed-off-by tag asserting authorship and permission to contribute, per the Developer Certificate of Origin. This tag can be added automatically by git using git commit -s.

Once you do that, I can merge this PR.

sergey-suloev commented 2 years ago

I didn't understand what I should do to comply

On Sun, Oct 3, 2021 at 10:58 PM Samuel Holland @.***> wrote:

Thanks for sending this. I assume you tried using the firmware and it works? It would be good to include in the commit message what you tested: if you tried suspend/resume, power button, IR remote, RTC wake, etc.

Also, please update your commit author/message, per the contribution guidelines https://github.com/crust-firmware/crust/blob/master/CONTRIBUTING.md:

All contributions to this project must be released under the open-source license used by the project. To help ensure this, all commits you make must be accompanied by your real name and a Signed-off-by tag asserting authorship and permission to contribute, per the Developer Certificate of Origin https://developercertificate.org/. This tag can be added automatically by git using git commit -s.

Once you do that, I can merge this PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/crust-firmware/crust/pull/194#issuecomment-933015749, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABP5DS7B7UP5APYNOTXOZBDUFCYWBANCNFSM5FEDZMSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Best regards, Sergey Suloev

smaeul commented 2 years ago

I didn't understand what I should do to comply

Mostly I want to know how much testing you did with the firmware, and if it worked correctly. That way if something breaks in the future, I know if "it worked before". Since I don't have this hardware, I cannot test anything myself.

I can take care of the other formalities when merging.

sergey-suloev commented 2 years ago

Of course I tested, it works

On Sun, Oct 3, 2021 at 11:24 PM Samuel Holland @.***> wrote:

I didn't understand what I should do to comply

Mostly I want to know how much testing you did with the firmware, and if it worked correctly. That way if something breaks in the future, I know if "it worked before". Since I don't have this hardware, I cannot test anything myself.

I can take care of the other formalities when merging.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/crust-firmware/crust/pull/194#issuecomment-933019581, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABP5DSY4SUEJ6VYYJH5RMGDUFC3YFANCNFSM5FEDZMSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Best regards, Sergey Suloev

smaeul commented 2 years ago

Merged as a194bdb192281baa3347a32aa6e45b9082517b4f.