crust-firmware / crust

SCP (power management) firmware for sunxi SoCs
Other
155 stars 34 forks source link

Fix build using GCC 12.x #209

Closed katyo closed 1 year ago

katyo commented 2 years ago

I have linking error like the following:

|   LD      .../crust/2022.09.13-r0/build/scp/scp.elf
| .../crust/2022.09.13-r0/recipe-sysroot-native/usr/bin/../lib/gcc/or1k-none-elf/12.2.0/../../../../or1k-none-elf/bin/ld: warning: .../crust/2022.09.13-r0/build/scp/scp.elf has a LOAD segment with RWX permissions
| collect2: error: ld returned 1 exit status
| make: *** [Makefile:197: .../crust/2022.09.13-r0/build/scp/scp.elf] Error 1
| make: Leaving directory '.../crust/2022.09.13-r0/git'

Purpose

Considerations for reviewers

Closes #

z3ntu commented 2 years ago

Add "Fixes #207" ?

smaeul commented 1 year ago

When was this linker option added? I don't think I want to break compatibility with older binutils versions by adding the option unconditionally.

serhii-nakon commented 1 year ago

@smaeul You can add this patch https://github.com/serhii-nakon/u-boot-opi3/blob/master/patches/0001-add_ability_set_ldflags.patch it shouldn't break anything due this parameter user will add by environment variable

katyo commented 1 year ago

Closed in favor of #210.