Closed GoogleCodeExporter closed 9 years ago
This is probably a pathname issue in src/jake2/tooks/Downloader.java.
I am not sure if the error is on line 127 (i.e zip path names are translated)
or 128 (if zip path names are not
converted)....
If somebody can try a fix for this on a windows machine (I don't have access to
one), I am happy to patch it in...
Original comment by stefan.haustein
on 9 Apr 2010 at 8:36
The revision 56fc48d7fa should fix this issue. Is there a good way to link the
revision and its issue?
Original comment by matthias.buchner
on 13 Apr 2010 at 6:23
Can you post a hg diff here? I think the revision is on your local system (not
accessible via the link)
Original comment by stefan.haustein
on 14 Apr 2010 at 10:56
Stephan,
The change is available on my clone.
http://code.google.com/r/matthiasbuchner-quake2-gwt-port/source/detail?r=56fc48d
7fa4c19c232e4819936d92ae577984520
It is my first time contributing on Google code. I understand I can push a
modification to my clone, you can audit it and eventually merge it with the main
line. Is this correct?
I did not mean to have this link in my comment. I am not sure why it is there!
:D
Original comment by matthias.buchner
on 15 Apr 2010 at 12:06
By the way, I have the code ready for the issues 19 and 20. I will push them if
you
change their status to "accepted".
Thanks.
Original comment by matthias.buchner
on 15 Apr 2010 at 12:09
Matthias: Mind if I just add you as a committer and let you push these changes?
Most of us aren't on Windows
boxes, and could use a hand keeping the build going there. I'll need your email
address to add you, though.
Original comment by joelgwebber
on 15 Apr 2010 at 2:05
Sure. My email is now public on my profile.
However, I realized the problem is not entirely solved. I pushed a new revision
but I
am now getting a BufferUnderflowException when converting doomgal.pcx. I will
let you
know how it goes!
Original comment by matthias.buchner
on 16 Apr 2010 at 4:15
in class jake2.tools.Unpak
the method createPath convertFile
from
// outFile.createNewFile();
to
outFile.createNewFile();
the method createPath
the second line add
if (index == -1) {
index = path.lastIndexOf('\\');
}
and ran
Original comment by andrelui...@gmail.com
on 25 Apr 2010 at 2:22
Original comment by stefan.haustein
on 5 Jul 2010 at 10:06
Original issue reported on code.google.com by
cop...@gmail.com
on 5 Apr 2010 at 12:26