search

crustymonkey / py-sonic

A python library to wrap the Subsonic REST API
http://stuffivelearned.org/doku.php?id=programming:python:py-sonic
GNU General Public License v3.0
56 stars 26 forks source link

SSL handling #13

Closed globin closed 8 years ago

globin commented 8 years ago

follow up to #5

crustymonkey commented 8 years ago

This looks good (and thanks for removing the old, extraneous pprint import). I'll test this out, but it looks like it should be fine, and then merge it. Thanks for the pull request!

crustymonkey commented 8 years ago

I tried this out with my server and this does not work. I haven't had a chance to dig in as to why, but the methods I'm using for connecting work fine. That said, you are correct that the current methods I'm using aren't going to work forever.

If you are interested, here's my relevant apache SSL conf items:

SSLProtocol all -SSLv2 -SSLv3 SSLCipherSuite ALL:!ADH:!EXPORT:!SSLv2:AES128-SHA:RC4+RSA:+HIGH:+MEDIUM:+LOW

crustymonkey commented 8 years ago

I've made some changes to the SSL discovery that should fix current issues and be forward compatible.