search

crutchcorn / WMIControl

WMI scanner, asset management medium, and management software
Mozilla Public License 2.0
12 stars 4 forks source link

Network picker runs twice #42

Closed crutchcorn closed 7 years ago

crutchcorn commented 7 years ago

image

This is due to the precompiled arguments in the network file (I'm very tired. Probably using the wrong terminology)

crutchcorn commented 7 years ago

Honestly, the network picker is going about things the wrong way. What should be done is to store the information in the newly created JSON file. Check if there is a default and set it permanently. I am currently looking for unique identifiers in WMI for network devices so I can see how viable this option is

crutchcorn commented 7 years ago

I'm kinda forgetting a pretty viable method of unique identification for network devices: MACAddress

typedrat commented 7 years ago

@crutchcorn You can't trust MAC addresses to be unique, not fully. A lot of poor quality Chinese stuff will use one MAC over and over and over, instead of following the rules.

crutchcorn commented 7 years ago

And yes, I get that, but: 1) I can't exactly be faulted for hardware issues can I? 2) Windows tends not to handle unique perminance of identifying hardware (you know, because of the reason you mentioned) 3) I just need the code working in general right now

On Sat, Apr 29, 2017, 7:45 PM Alexis Williams notifications@github.com wrote:

@crutchcorn https://github.com/crutchcorn You can't trust MAC addresses to be unique, not fully. A lot of poor quality Chinese stuff will use one MAC over and over and over, instead of following the rules.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/crutchcorn/WMIControl/issues/42#issuecomment-298207376, or mute the thread https://github.com/notifications/unsubscribe-auth/AIrbiYRt-fEzzb1wktr15OfpcdzL03mFks5r0_XagaJpZM4NIbuF .

crutchcorn commented 7 years ago

Speaking of which, the code is finished. I'll have it up sometime this weekend most likely. Fairly simple implementation

On Sat, Apr 29, 2017, 7:48 PM Corbin Crutchley crutchcorn@gmail.com wrote:

And yes, I get that, but: 1) I can't exactly be faulted for hardware issues can I? 2) Windows tends not to handle unique perminance of identifying hardware (you know, because of the reason you mentioned) 3) I just need the code working in general right now

On Sat, Apr 29, 2017, 7:45 PM Alexis Williams notifications@github.com wrote:

@crutchcorn https://github.com/crutchcorn You can't trust MAC addresses to be unique, not fully. A lot of poor quality Chinese stuff will use one MAC over and over and over, instead of following the rules.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/crutchcorn/WMIControl/issues/42#issuecomment-298207376, or mute the thread https://github.com/notifications/unsubscribe-auth/AIrbiYRt-fEzzb1wktr15OfpcdzL03mFks5r0_XagaJpZM4NIbuF .

typedrat commented 7 years ago

Wasn't even "don't do it", more of a note to make sure that it's on hand if a problem like that does show up.

crutchcorn commented 7 years ago

I gotcha. I'll be sure to document

On Sat, Apr 29, 2017, 7:49 PM Alexis Williams notifications@github.com wrote:

Wasn't even "don't do it", more of a note to make sure that it's on hand if a problem like that does show up.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/crutchcorn/WMIControl/issues/42#issuecomment-298207489, or mute the thread https://github.com/notifications/unsubscribe-auth/AIrbiX6QOkwiEwK6N1a2ti460tH2MVxnks5r0_a8gaJpZM4NIbuF .