search

crux-bphc / CMS-Android

A custom Moodle app for the students of BITS Pilani, Hyderabad Campus.
MIT License
28 stars 39 forks source link

Shifted TokenActivity to use a ViewModel and switched its usage of ProgressDialog #327

Closed aryanarora180 closed 3 years ago

aryanarora180 commented 3 years ago

All of TokenActivity's business logic has been shifted to a ViewModel. Its usage of AsyncTask has been shifted to use Coroutines, LiveData, and Observers. Moreover, the usage of deprecated ProgressDialog has also been switched to a simple ProgressBar and accompanying text on the screen. Login screen Login screen - fetching data

abhijeetviswa commented 3 years ago

This looks good. A change for the better. I've left some comments and reviews. Also, update the changelog and amend b1b4172c9455e9c7c99d272223002d4be14115e5. The commit subject can also rewritten to something like: "Replace TokenActivity ProgressDialog with on screen prompts".