search

crux-bphc / CMS-Android

A custom Moodle app for the students of BITS Pilani, Hyderabad Campus.
MIT License
28 stars 39 forks source link

Fix deletion snackbar visibility issue. #343

Closed plaidbait91 closed 2 years ago

plaidbait91 commented 2 years ago

Snackbar message is now clearly visible on deletion.

Light mode: 491efce4-547c-4306-9bec-f9544e87fd29

Dark mode: 54334408-d9e6-497b-86e1-7f779febf047

abhijeetviswa commented 2 years ago

Please give a more descriptive commit message.

plaidbait91 commented 2 years ago

Updated title of pull request and provided screenshots.

aryanarora180 commented 2 years ago

You've changed the title of the PR, change the title of the commit too. You can also add some more details such as "in dark mode" and "in file manager".

abhijeetviswa commented 2 years ago

Update the commit message as well.

git commit --amend will open up an editor to change the commit message. After amending, you'll have to force push the changes.

The contributor guidelines should have details on how to create good commit messages. Also check out commit messages from previous commits.

aryanarora180 commented 2 years ago

Last thing: Add this change to the changelog