search

crux-bphc / chronofactorem-rewrite

A rewrite of our ChronoFactorem project
https://www.chrono.crux-bphc.com/
MIT License
12 stars 3 forks source link

PoE and PoM clash #206

Open rakshita-vijay opened 1 month ago

rakshita-vijay commented 1 month ago

If a student chooses one, the other should not be available, else it shows that the compres clash.

skoriop commented 1 month ago

This was probably caused by #186 considering that's the only PR that affected that part of the codebase, we'll look into it.

skoriop commented 1 month ago

@rakshita-vijay We've pushed a hotfix for this, can you try creating a new timetable and verifying if it works?

rakshita-vijay commented 1 month ago

okay, will try

rakshita-vijay commented 1 month ago

doesn't show up as a clash, PoM still visible though

skoriop commented 1 month ago

doesn't show up as a clash, PoM still visible though

Ok, that's the expected behaviour for now. We'll look into not displaying an unselected optional course in time for the next release (which will be when the main timetable is out) since I don't think this is urgent enough to need another series of hotfixes.

Thanks a lot for reporting this though, we'll keep this issue open until we've done the above and figure out exactly why #186 caused this.

rakshita-vijay commented 1 month ago

Yes, of course, thank you!

No problem, cool!