crwlrsoft / crawler

Library for Rapid (Web) Crawler and Scraper Development
https://www.crwlr.software/packages/crawler
MIT License
325 stars 11 forks source link

Improve variable names #113

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

Currently there are ~300 lines with names like key, value, data. Please consider using informative variable names. source

// For example
protected function setDomain(string $value, bool $viaAttribute = false): void {}
protected function setDomain(string $domainName, bool $viaAttribute = false): void {}
otsch commented 1 year ago

Those occurrences don't have to be bad per se. For example some occurrences are even dictated by PSR interfaces, like in the CacheInterface of PSR-16, which absolutely make sense. As I don't really see a big "issue" here, I'll close this. Send a PR if you like to improve some particular variable names.