Open thdoan opened 1 year ago
Vite
When running vite build the generated manifest.json doesn't end in a Unix newline, which gets a warning in Vim. It would be nice to end the file with \n.
vite build
manifest.json
\n
N/A (running vite build on a local project)
No response
System: OS: Windows 10 10.0.19044 CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz Memory: 13.66 GB / 31.95 GB Binaries: Node: 16.19.1 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.17 - ~\home\.yarn\bin\yarn.CMD npm: 8.19.3 - C:\Program Files\nodejs\npm.CMD Browsers: Edge: Spartan (44.19041.1266.0), Chromium (110.0.1587.69) Internet Explorer: 11.0.19041.1566 npmPackages: @crxjs/vite-plugin: ^2.0.0-beta.9 => 2.0.0-beta.9 vite: ^4.0.2 => 4.0.2
annoyance
This would be easy to do, I'd look here:
https://github.com/crxjs/chrome-extension-tools/blob/534a5b64a4543281ac062e6fbe6761eb54491ca2/packages/vite-plugin/src/node/plugin-manifest.ts#L395
PR's are welcome 😺
Build tool
Vite
Where do you see the problem?
Describe the bug
When running
vite build
the generatedmanifest.json
doesn't end in a Unix newline, which gets a warning in Vim. It would be nice to end the file with\n
.Reproduction
N/A (running
vite build
on a local project)Logs
No response
System Info
Severity
annoyance