crxjs / chrome-extension-tools

Bundling Chrome Extensions can be pretty complex. It doesn't have to be.
https://crxjs.dev/vite-plugin
2.75k stars 182 forks source link

Docs: The screen shot is old and there is redudant code screenshot #674

Closed jaiakash closed 1 year ago

jaiakash commented 1 year ago

Where do you see the problem?

Describe the bug

  1. The picture shown at page https://crxjs.dev/vite-plugin/getting-started/react/dev-basics is old, we should have new screenshot.
  2. The code shown in same page is redundant. So i suggest to use a different screenshot for showing HMR and inspect.

I have updated the code in my fork. Shall i send a PR for same? Do let me know if there are any changes.

Reproduction

Open link: https://crxjs.dev/vite-plugin/getting-started/react/dev-basics Github: https://github.com/crxjs/chrome-extension-tools/blob/main/packages/vite-plugin-docs/docs/getting-started/react/01-dev-basics.md

jaiakash commented 1 year ago

Old image

New Screenshot from 2023-03-23 02-17-14