search

crybapp / api

Core service used to handle events from clients
MIT License
36 stars 8 forks source link

Move to eslint #92

Closed wolfy1339 closed 4 years ago

wolfy1339 commented 4 years ago

There's a couple of issues left, but they require a deeper refactoring


cryb/api/src/config/passport.config.ts
  15:4   error  Promise returned in function argument where a void return was expected  @typescript-eslint/no-misused-promises
  40:24  error  Promise returned in function argument where a void return was expected  @typescript-eslint/no-misused-promises

cryb/api/src/drivers/portals.driver.ts
  16:57  error  Promise returned in function argument where a void return was expected  @typescript-eslint/no-misused-promises
  33:58  error  Promise returned in function argument where a void return was expected  @typescript-eslint/no-misused-promises

✖ 4 problems (4 errors, 0 warnings)
darnfish commented 4 years ago

@JeDaYoshi Can we merge this? Sorry for the late reply!! Ty for the work <3

JeDaYoshi commented 4 years ago

I was going to do this, but I don't remember the exact reason I didn't, possibly since I was working on my changes - but sure, go ahead.