crybapp / web

Main web client for Cryb
MIT License
45 stars 14 forks source link

Better control bar #116

Open darnfish opened 4 years ago

darnfish commented 4 years ago

This PR extracts ControlBar to a separate component and places it in player. This also includes support for the updated design which requires a @cryb/borealis update

darnfish commented 4 years ago

Opened a PR over at Borealis: https://github.com/crybapp/borealis/pull/3

JeDaYoshi commented 4 years ago

While this seems nice, and I was planning to move the control bar to a separate component that's included in Player, I am not sure of the way it is being done because I feel it can cause problems in controlling the VM in case you need to click things on the bottom, hence me wanting to avoid putting the controls over the video all this time. I'm not sure, though, but I feel the rest should have a say on this one, too.

darnfish commented 4 years ago

The control bar is hidden if you're the controlling the VM; I could work on something that moves the control bar under the player if you're currently controlling the VM instead of just removing it outright?

JeDaYoshi commented 4 years ago

That could possibly work and fit better.

darnfish commented 4 years ago

Here's a small mockup: the user can bring their cursor to the right side of the preview area and it'll bring up the control bar. As most users are using Cryb on their desktop with wider screens this hit-region should hopefully be on the black bars. Only issue is it isn't very intuitive to figure out, might be worth adding a tip/alert that it's possible. Or I could add a small FAB to the bottom right on the player to do the same thing.

screencast 2020-05-30 02-16-00