cryingpotat0 / n8n-ntfy.sh

MIT License
17 stars 2 forks source link

Where to input the custom ntfy server? #2

Open benborges opened 1 year ago

benborges commented 1 year ago

In the use case of a private ntfy server, that has user management in place, where the notification can only be created by an authorised client, how/where do I specify the server and where do I handle Auth?

Currently all of this can be done with the Basic Auth and the HTTP node but being able to use to use this node would just make everything simpler, I don't mind testing and reporting until features reach parity.

Joffcom commented 1 year ago

Hey @benborges,

I was just looking at that, It looks like it is planned for the future. May have to sneak in a PR over the weekend for it.

cryingpotat0 commented 1 year ago

Hey! Can you point me to the ntfy docs about an authorized client? I added support for a custom ntfy server last week, but didn't realize there were authorization options here. @Joffcom would love a PR adding to this!

cryingpotat0 commented 1 year ago

This is where you add the custom server today: https://github.com/raghavanand98/n8n-ntfy.sh/commit/4d934389f7d1522d750333eaf45d26f518806212

benborges commented 1 year ago

Hey! Can you point me to the ntfy docs about an authorized client? I added support for a custom ntfy server last week, but didn't realize there were authorization options here. @Joffcom would love a PR adding to this!

This is where the doc mention it : https://docs.ntfy.sh/publish/?h=auth#authentication

benborges commented 1 year ago

This is where you add the custom server today: 4d93438

Ok waiting for the new release to try this

cryingpotat0 commented 1 year ago

Can you use the auth token in the URL approach? https://docs.ntfy.sh/publish/?h=auth#query-param

benborges commented 1 year ago

with the HTTP node I use the basic auth with the user/password of my ntfy custom server and it works yes

benborges commented 1 year ago

Can you use the auth token in the URL approach? https://docs.ntfy.sh/publish/?h=auth#query-param

I could try but I still can't see the URL field on my node mobule, it's still the same version, it's like this new custom URL field hasn't been published to npm?

cryingpotat0 commented 1 year ago

It should have been published already: https://www.npmjs.com/package/n8n-nodes-ntfy Can you try upgrading the node in n8n? https://docs.n8n.io/integrations/community-nodes/installation/

ZergRael commented 1 year ago

It should have been published already: https://www.npmjs.com/package/n8n-nodes-ntfy Can you try upgrading the node in n8n? https://docs.n8n.io/integrations/community-nodes/installation/

Based on NPM latest version (currently 0.1.5) date & the date of your commit, I'm pretty sure the fix has not been pushed to NPM yet https://www.npmjs.com/package/n8n-nodes-ntfy/v/0.1.5 : 2023-02-23 f9c892013d279f7815162d8a48ebc1e561282869 : 2023-03-06

Could you try to publish a new version ? Thanks !

cryingpotat0 commented 1 year ago

Published! Thanks for spotting that inconsistency

benborges commented 1 year ago

Got it ! but sadly I can't yet use it because my ntfy instance need me to be auth to publish, this is a use case that will come often, if you have a private ntfy server, you probably don't want anybody to publish to topics, in my case, some topics are read-only and can be used by the public but all topics need auth to write :/

image

benborges commented 1 year ago

So I tried to use the ?auth:token just after the topic name but it does not seem to be working

cryingpotat0 commented 1 year ago

I can look this weekend! Are you running it on a custom domain or is there a way to configure ntfy.sh to be authenticated?

skrollme commented 7 months ago

Any news on the custom authentication topic?