search

cryo28 / sidekiq_status

Extension to Sidekiq to pass job execution metadata such as status and result back to the client
MIT License
152 stars 53 forks source link

Allow to work with the Sidekiq retry mechanism #26

Closed dedene closed 8 years ago

dedene commented 10 years ago

This fixes #18 for us.

dingzj commented 10 years ago

suffer from this error too, why error during the CI build? can we merge?

dedene commented 10 years ago

It seemed the build failed for one specific situation: https://travis-ci.org/cryo28/sidekiq_status/jobs/21515050 not sure why, but unlikely this was caused by the changes in this PR.

We are using the changed code in production for several months now, without any issues.

dingzj commented 10 years ago

thanks, It is indeed works. Anyway, I am using the other one sidekiq-status, want to make unique jobs; yours seems not working in conjunction with sidekiq-unique-jobs.

cryo28 commented 8 years ago

@dedene Please test whether sidekiq_status 1.1.0 works well with retry in your use case. There were a change to jid handling,now sidekiq_status does not wrap sidekiq job payload, so it should integrate better with various sidekiq features

cryo28 commented 8 years ago

@dedene Please reopen if you still have issues with the new version.