cryo28 / sidekiq_status

Extension to Sidekiq to pass job execution metadata such as status and result back to the client
MIT License
152 stars 53 forks source link

Adds support for Sidekiq 4.2+ #42

Closed ncuesta closed 8 years ago

ncuesta commented 8 years ago

This Pull Request adds support for Sidekiq version 4.2 and up, by removing calls to Sinatra's to method and replacing them with the new way to go, as seen on Sidekiq's templates (using root_path).

This allows for using this great gem with the new Sidekiq::Web, which does not depend on Sinatra anymore.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-58.4%) to 39.267% when pulling f56cca934ff51c96ad24961cf05163f2f148c8c8 on ncuesta:sidekiq-4.2-support into 486c0baf0b08044f632317de5dc0ec027847c45e on cryo28:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-58.4%) to 39.267% when pulling f56cca934ff51c96ad24961cf05163f2f148c8c8 on ncuesta:sidekiq-4.2-support into 486c0baf0b08044f632317de5dc0ec027847c45e on cryo28:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-58.4%) to 39.267% when pulling f56cca934ff51c96ad24961cf05163f2f148c8c8 on ncuesta:sidekiq-4.2-support into 486c0baf0b08044f632317de5dc0ec027847c45e on cryo28:master.