search

cryogen-project / cryogen-core

Cryogen's core
Eclipse Public License 1.0
69 stars 62 forks source link

Clean URLs with and without trailing slash #119

Closed niamu closed 5 years ago

niamu commented 5 years ago

Full disclosure; I haven't tested this yet. I'll get around to testing it in the next day or so.

This work represents most of the solution I outlined here: https://github.com/cryogen-project/cryogen/issues/166#issuecomment-493294999

Once this branch is confirmed completed and ready to be merged, there are still clean-urls? references in cryogen-project/cryogen that also need to be addressed as well as documentation updates that will be necessary.

lacarmen commented 5 years ago

The changes look good to me (I haven't tested yet either though 😄) Are you going to be adding more to this PR?

niamu commented 5 years ago

Assuming this works, this specific PR won't need anything additional. I'll just need to make changes to the cryogen repository as well and then look into documentation changes.

niamu commented 5 years ago

Finally found some time to test this out and fixed up the remaining bugs with it. I've also created https://github.com/cryogen-project/cryogen/pull/181 which only leaves documentation changes which I will get to shortly.

niamu commented 5 years ago

Documentation changes are here: https://github.com/cryogen-project/cryogen-docs/pull/22