search

cryogen-project / cryogen-core

Cryogen's core
Eclipse Public License 1.0
69 stars 62 forks source link

<!-more-> marker characters #151

Closed daverclarke closed 3 years ago

daverclarke commented 3 years ago

Hi,

I've just upgraded from an older version of cryogen to 0.3.2 and the more marker as a preview break stopped working. I still see "<!–more–>" in the documentation, but it doesn't seem to be working.

holyjak commented 3 years ago

It works for me (using cryogen-asciidoc and wrapping it with +++). What version have you upgraded from?

It should be <!--more--> (two -, no spaces) but I assume you have that. Is your site online somewhere?

You could put some logs into https://github.com/cryogen-project/cryogen-core/blob/1b44acd0c3b467578975f454fe1be79317d90784/src/cryogen_core/compiler.clj#L360 to troubleshoot why it is not found anymore. You can use clojure and the deps.edn from https://github.com/cryogen-project/cryogen/pull/221/files?file-filters%5B%5D=.edn#diff-137441572733db311b7e1f41445ed6643e41c6007e008fc056b5cf150466e22fR1 to simplify using a modified version of cryogen-core for the test.

Or if you share a small reproducible example (one that I can git checkout or unzip), I could have a look, perhaps.

daverclarke commented 3 years ago

Aha,

The two dashes is probably the difference as that does work. I'm coming from 0.2.1 to the current version. I do notice on the doco page (http://cryogenweb.org/docs/customizing-the-index.html) it still lists the single dash <!-more-> as the break.

holyjak commented 3 years ago

Title correction: Fix the docs to show -- as-is

Somehow, the -- becomes – (unicode 8211) so we need to fix the docs to stop doing that.

holyjak commented 3 years ago

The docs will be fixed once cryogen-project/cryogen-docs#33 is merged and the site rebuilt.

lacarmen commented 3 years ago

Thank you @holyjak ❤️