search

cryogen-project / cryogen-core

Cryogen's core
Eclipse Public License 1.0
69 stars 62 forks source link

#161: Proposed fix #162

Closed simon-brooke closed 1 year ago

simon-brooke commented 1 year ago

As discussed, this fix requires no change to existing themes. I shall be submitting a separate pull request to cryogen with rework to themes to generate better OpenGraph meta-tags, but these changes do not depend on that rework.

yogthos commented 1 year ago

Looks great overall, would you mind also updating the docs in the README.MD? :) Otherwise, I'm good to merge.

simon-brooke commented 1 year ago

OK, not clear which README you want changes in. I've pushed an update to cryogen-project.cryogen adding config documentation to the README; there's no documentation in the README of cryogen-project.cryogen-core. I do need to document the changes to allow meta-data to be inferred from plain Markdown (and presumably asciidoc, too, although I've not checked this), but that needs to be a change to this page and I'm not sure where to edit that!

yogthos commented 1 year ago

Ah yeah it would probably be best to update the docs site since I assume that's what most people will look at, the source for the site is here https://github.com/cryogen-project/cryogen-docs/tree/master/content/md/docs

simon-brooke commented 1 year ago

Sorry! Found that and sent you a pull request on that one now!

While I have your attention, where in the source code does the markdown parser get instantiated? I've written a function to detect whether there are any klipse code snippets in the document, and I'm trying to write unit tests for it, but I cannot find how to parse markdown text!

I see you wrote a markdown parser, but that's not a dependency; and I can't find any other dependency which implements markdown (or asciidoc) parsing.

yogthos commented 1 year ago

ok we should be all set, just pushed out new core and template to Clojars, thanks again for the pr :)