search

cryogen-project / cryogen-core

Cryogen's core
Eclipse Public License 1.0
69 stars 62 forks source link

URL encode the author URI. #169

Closed bombaywalla closed 3 months ago

bombaywalla commented 3 months ago

The URI for each author page was not URL-encoded. Now it is.

yogthos commented 3 months ago

Would it be better to handle this in page-uri directly?

bombaywalla commented 3 months ago

Possibly.

But I saw that the encoding was being done for tags independently by tag-info and was afraid that I might miss some other independent encodings and double-encode some URI somewhere.

My general feeling is that encodings should be done on URL fragments just before they are put together to form the URL, and at the last call-site that the semantics of the fragment are known. Mainly to avoid double-encoding fragments that are only supposed to be encoded once.

I don't know whether that philosophy would apply here. So, am willing to handle it in page-uri if you'd prefer.

Just let me know.

yogthos commented 3 months ago

If you're up for it, I think it'd probably be better to just consolidate this in one place. Otherwise, I can see this coming up again. :)

bombaywalla commented 3 months ago

Okay. I'll take a stab at it tomorrow.

yogthos commented 3 months ago

Sounds good, and I can help take a look over as well after. Should be pretty safe.

yogthos commented 3 months ago

Looks great, just pushed out 0.4.6 with the changes. Thanks again for spearheading this!

bombaywalla commented 3 months ago

You're welcome. Thanks for pushing a new version.