search

cryogen-project / cryogen-core

Cryogen's core
Eclipse Public License 1.0
69 stars 62 forks source link

Enable Sass in themes #91

Closed KingMob closed 7 years ago

KingMob commented 7 years ago

This also fixed a few inconsistencies in how the css directory is handled.

NB: the :sass-dest key is no longer used. The code separates Sass compilation from copying files into public/ so all Sass files are not compiled into their directory.

Fixes #90.

An accompanying change to the Leiningen template repo will ensure there's a css directory by default.

There's also some minor text changes, and a little more output about copying resources. I guessed you wouldn't mind those, but let me know if you want to keep the PR simpler.

KingMob commented 7 years ago

Also see PR 147 in the main repo that fixes a few related inconsistencies.

KingMob commented 7 years ago

You got it. Will fix and update.

KingMob commented 7 years ago

OK, take a look now?

lacarmen commented 7 years ago

Looks good, thank you!

KingMob commented 7 years ago

Great! I'll check out the latest and try it on my end.

lacarmen commented 7 years ago

Give it a minute, I have to tweak a couple of things so it aligns with the new schema validations :)

KingMob commented 7 years ago

OK, no prob.

lacarmen commented 7 years ago

Ok give it a try now. I know you tried to keep backwards compatibility by allowing sass-src to be a string or a vector of strings, but I had to change it to always be a vector of strings for the schema stuff. I'll make sure to note it in the release docs.