search

cryogen-project / cryogen

A simple static site generator written in Clojure
http://cryogenweb.org/
Eclipse Public License 1.0
1.1k stars 96 forks source link

Bug: Wrong context on some layouts #185

Closed ghost closed 4 years ago

ghost commented 5 years ago

Hi great job w/ Cryogen :)

I've recently tried to make a Cryogen theme and found some interesting bugs (mostly unexpected values from each layout context):

  1. author.html uses home as :active-page value => Expected: author to reflect its layout
  2. tag.html and tags.html both uses tags as :active-page value => Expected: tag for tag.html
  3. home.html and previews.html has :post context on :page keyword => Expected: :page should have page-related contexts
  4. toc seems to start at h3 downwards and there's no option to change it => Expected: Should start at h2 (or at least have an option to specify starting point)
lacarmen commented 5 years ago

Hi, glad you're enjoying the project :)

1-3 should be easy to fix. I've have to take a closer look to see what's going on with 4.

Since you're working on a theme, would you be interested in submitting a PR for this?

ghost commented 5 years ago

Hi,

Correct, no. 1 and no. 2 is fixable with selmer blocks; no. 3 can just ignore :page context. On no. 4; it's really outside any context iirc.

Regarding the theme, sure, I'd gladly send a PR once it's finished :)