cryos / avogadro

Avogadro 1 is not under active development, the repository was archived in September 2021. Development of Avogadro 2 is being done at https://github.com/openchemistry/avogadrolibs. Avogadro is an advanced molecular editor designed for cross-platform use in computational chemistry, molecular modeling, bioinformatics, materials science, and related areas.
http://avogadro.cc/
GNU General Public License v2.0
334 stars 156 forks source link

Version 1.2.0: Build fails: controlling expression type 'int' not compatible with any generic association type #916

Open yurivict opened 5 years ago

yurivict commented 5 years ago
libavogadro/src/extensions/symmetry/libmsym/src/orbital.c:70:24: error: controlling expression type 'int' not compatible with any generic association type
            char *d = (signbit(m) == 1 ? "-" : "+");
                       ^~~~~~~~~~
/usr/include/math.h:134:20: note: expanded from macro 'signbit'
#define signbit(x) __fp_type_select(x, __signbitf, __signbit, __signbitl)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/math.h:82:48: note: expanded from macro '__fp_type_select'
#define __fp_type_select(x, f, d, ld) _Generic((x),                     \
                                               ^~~
libavogadro/src/extensions/symmetry/libmsym/src/orbital.c:76:24: error: controlling expression type 'int' not compatible with any generic association type
            char *d = (signbit(m) == 1 ? "-" : "+");
                       ^~~~~~~~~~
/usr/include/math.h:134:20: note: expanded from macro 'signbit'
#define signbit(x) __fp_type_select(x, __signbitf, __signbit, __signbitl)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/math.h:82:48: note: expanded from macro '__fp_type_select'
#define __fp_type_select(x, f, d, ld) _Generic((x),                     \
                                               ^~~
2 errors generated.

FreeBSD 11.2 clang-6

yurivict commented 5 years ago

m is int and signbit expects a floating-point type.