search

cryostatio / cryostat-core

Core library providing a convenience wrapper and headless stubs for managing JFR with JDK Mission Control API
https://cryostat.io/
Other
8 stars 21 forks source link

[Task] Refactor JMC related code when upstream refactoring is complete #173

Closed Josh-Matsuoka closed 4 months ago

Josh-Matsuoka commented 1 year ago

Currently we're embedding classes from the flightrecorder, rjmx, jdp, and ui/common. There's an ongoing effort to refactor flightrecorder.configuration and ui.common into jmc-core. Once this upstream refactoring is done and the changes are available on maven central we should update cryostat accordingly.

Depends on the following upstream issues: https://bugs.openjdk.org/browse/JMC-7308 https://bugs.openjdk.org/browse/JMC-7307

Related: https://github.com/cryostatio/cryostat-core/issues/95 https://github.com/cryostatio/cryostat-core/issues/22

aptmac commented 4 months ago

Just noticed that there were a couple of issues still open related to the dependency on jmc/application.

This was addressed in commit https://github.com/cryostatio/cryostat-core/commit/34c5e0e423069c748553a4a51c4c3f5c9fda5e54.