search

cryostatio / cryostat-core

Core library providing a convenience wrapper and headless stubs for managing JFR with JDK Mission Control API
https://cryostat.io/
Other
8 stars 21 forks source link

[Bug] JMC Agent Probe Template schema is in the wrong package #450

Open andrewazores opened 2 months ago

andrewazores commented 2 months ago

See #398

https://github.com/cryostatio/cryostat-core/blob/main/cryostat-core/src/main/resources/io/cryostat/core/agent/jfrprobes_schema.xsd

This causes probe template uploads to fail because the template service cannot load the schema to validate the uploaded file.

andrewazores commented 2 months ago 
$ tree cryostat-core/src/main/resources/
cryostat-core/src/main/resources/
├── config
│   └── logging.properties
├── io
│   └── cryostat
│       └── core
│           └── agent
│               └── jfrprobes_schema.xsd
├── org
│   └── openjdk
│       └── jmc
│           ├── flightrecorder
│           │   └── configuration
│           │       └── events
│           │           ├── jfc_v1.xsd
│           │           └── jfc_v2.xsd
│           └── rjmx
│               └── subscription
│                   └── internal
│                       └── mrimetadata.xml

Do we still need the org.openjdk.jmc XML and XSD files here after we removed the JMC embedded sources fork?

Josh-Matsuoka commented 2 months ago

I don't see any uses of those anymore in core or cryostat3, they should be safe to remove but I'll double check.

andrewazores commented 4 weeks ago

@Josh-Matsuoka did you get a chance to check on whether those files can be removed?