search

cryostatio / cryostat-grafana-dashboard

Apache License 2.0
0 stars 6 forks source link

fix(dashboard): use fixed text color for stat panels #21

Closed tthvo closed 1 year ago

tthvo commented 1 year ago

Related to https://github.com/cryostatio/cryostat-web/pull/856

This includes fix to panel text to specify single text color with text variant.

Dark Theme

Screenshot from 2023-02-08 20-19-39

Light Theme

Screenshot from 2023-02-08 20-19-51

andrewazores commented 1 year ago

Looks good. I wonder if there is a way to override settings like this via the embedded panel query parameters or some other dynamic mechanism, though.

tthvo commented 1 year ago

Been trying to find a way but seems like everything must be configured via the JSON model. I think the user can change the styling via panel editor if they are authenticated (maybe admin?). Maybe we can figure a way to embed/anchor to the editor view and somehow allow saving latest json model on top of the shipped base JSON?

andrewazores commented 1 year ago

That's a lot more work than I think is worth doing, honestly. I think this is good to go as it is.