search

cryostatio / cryostat-legacy

OUTDATED - See the new repository below! -- Secure JDK Flight Recorder management for containerized JVMs
https://github.com/cryostatio/cryostat
Other
224 stars 31 forks source link

target JVMs report a different default "toDisk" value from actual value used in new recordings #263

Open Alexjsenn opened 4 years ago

Alexjsenn commented 4 years ago

The default recording options can be retrieved from a target JVM using IFlightRecorderService::getAvailableRecordingOptions(). The map returned specifies the default values for different recording options. While testing (using the cjfr instance itself as a targetJVM) the JVM reports that the default value for toDisk is false. However, after creating a recording without specifying toDisk (which we assume would mean the JVM would fall back on its default), the recording is created with toDisk=true. Given this inconsistency, the toDisk checkbox in the new recordings page of the web-client has been set to default to true, thus requiring the user to specifically disable the option if they wish to.

tthvo commented 1 year ago

Hey @andrewazores, is there still something to do with issue? Just saw it mention in code:

https://github.com/cryostatio/cryostat-web/blob/ee99ad168f707e4342444589a466f9abb0ca6599/src/app/CreateRecording/CustomRecordingForm.tsx#L234

andrewazores commented 1 year ago

I haven't checked the behaviour since probably when this bug was filed. In the end I think we worked around it effectively enough so it hasn't been a priority to look at it again, but perhaps the underlying bug was fixed when we upgraded JMC versions in -core? If not, then I think it's still there.