Closed andrewazores closed 1 year ago
This is a JMC JFR parser bug and appears to have been fixed in upstream JMC:
https://github.com/openjdk/jmc/commit/ad9b602d9219c726239f848672ee27da96611254
Here is the corresponding OpenJDK bug:
I'm not familiar with what the steps are in this situation. Do we update our JMC JFR dependencies to include this upstream fix?
I'm not familiar with what the steps are in this situation. Do we update our JMC JFR dependencies to include this upstream fix?
There is already a -core PR in progress trying to do this: https://github.com/cryostatio/cryostat-core/pull/99
Unfortunately it's not quite so straightforward as simply bumping the JMC version referenced in the pom.xml
, because for downstream build reasons we also embed an older fork (7.1 IIRC) of some of the JMC sources directly into the -core sources (basically everything within https://github.com/cryostatio/cryostat-core/tree/main/src/main/java/org/openjdk/jmc). So all of those embedded sources would also need to be updated, which would probably mean deleting them all and copying the same directories out of the JMC 8.1.1 sources back into -core to re-embed the newest versions. So far this is all a pretty easy set of steps to take, but then there's a bit more legwork to do to ensure that everything is still buildable after this and everything still works as expected. I don't think JMC 8.1.1 is out yet, and as explained in that -core issue we can't use 8.1.0 (it fixes this NPE but breaks report generation altogether in a different way apparently).
Makes sense, thank you.
Once the JMC project gets their additional application bundles extracted out and moved into their JMC Core library and published somewhere like Maven Central then hopefully we can drop our embedded version of the sources, which will make future JMC version upgrades much simpler and cleaner for us.
Depends on: https://github.com/cryostatio/cryostat-core/issues/95
Cause: https://github.com/cryostatio/cryostat/issues/666#issuecomment-989105967
cryostat-itest-2021-08-27T19:05:18Z.log