cryostatio / cryostat-operator

A Kubernetes Operator to facilitate the setup and management of Cryostat.
https://cryostat.io
Apache License 2.0
33 stars 19 forks source link

fix(webhook): make label selectors unambiguous (backport #926) #927

Closed mergify[bot] closed 2 months ago

mergify[bot] commented 2 months ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

Fixes: #924

Description of the change:

Motivation for the change:

How to manually test:

  1. Install another operator with a webhook (e.g. Infinispan Operator)
  2. Deploy this PR into the same namespace
  3. Exercise webhooks by creating and modifying Cryostat CRs
    This is an automatic backport of pull request #926 done by Mergify.
mergify[bot] commented 2 months ago

Cherry-pick of 25de979ad44ba6a47e15bdf13a5035e0555eb2b0 has failed:

On branch mergify/bp/cryostat-v3.0/pr-926
Your branch is up to date with 'origin/cryostat-v3.0'.

You are currently cherry-picking commit 25de979.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   bundle/manifests/cryostat-operator-cryostat-namespaced_rbac.authorization.k8s.io_v1_clusterrole.yaml
    modified:   bundle/manifests/cryostat-operator-cryostat_rbac.authorization.k8s.io_v1_clusterrole.yaml
    modified:   bundle/manifests/cryostat-operator-manager-config_v1_configmap.yaml
    modified:   bundle/manifests/cryostat-operator-oauth-client_rbac.authorization.k8s.io_v1_clusterrole.yaml
    modified:   bundle/manifests/cryostat-operator-webhook-service_v1_service.yaml
    modified:   bundle/manifests/operator.cryostat.io_cryostats.yaml
    modified:   config/default/kustomization.yaml
    modified:   config/manifests/kustomization.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   bundle/manifests/cryostat-operator.clusterserviceversion.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

ebaron commented 2 months ago

/build_test

github-actions[bot] commented 2 months ago

/build_test completed successfully ✅. View Actions Run.