cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

chore(templates): remove auth token download flow #1215

Closed andrewazores closed 6 months ago

andrewazores commented 6 months ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to https://github.com/cryostatio/cryostat3/pull/290 Depends on https://github.com/cryostatio/cryostat3/pull/290

Description of the change:

Removes the old API v2.1 auth token download flow in the middle of the event template download action. In 3.0 the client can simply request the file.

Motivation for the change:

This enables the "Events -> Event Templates -> SomeTemplate -> Download" feature to work again with 3.0.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...
github-actions[bot] commented 6 months ago

This PR/issue depends on:

andrewazores commented 6 months ago

/build_test

github-actions[bot] commented 6 months ago

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1215-c5b864082901c3600dea8e4b95182d2f2e050ee3 bash smoketest.bash # then open http://localhost:8080
andrewazores commented 6 months ago

Accidentally deleted branch before merging...