cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

fix(graphql): emit notifications on server error response #1218

Closed andrewazores closed 6 months ago

andrewazores commented 6 months ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #65 Related to #410 Related to https://github.com/cryostatio/cryostat3/issues/11

Description of the change:

GraphQL queries which do not explicitly suppress notifications will emit a graphical notification box if there are GraphQL errors in the response.

Motivation for the change:

Previously, notifications would only be displayed if the GraphQL response status code was 4xx/5xx. With this change, 2xx responses which contain a GraphQL error response will also display notifications. This provides the user (or developer) more information about what went wrong with the request.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...
andrewazores commented 6 months ago

Useful when doing work like in https://github.com/cryostatio/cryostat3/pull/307 .

andrewazores commented 6 months ago

Example: image