GraphQL queries which do not explicitly suppress notifications will emit a graphical notification box if there are GraphQL errors in the response.
Motivation for the change:
Previously, notifications would only be displayed if the GraphQL response status code was 4xx/5xx. With this change, 2xx responses which contain a GraphQL error response will also display notifications. This provides the user (or developer) more information about what went wrong with the request.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #65 Related to #410 Related to https://github.com/cryostatio/cryostat3/issues/11
Description of the change:
GraphQL queries which do not explicitly suppress notifications will emit a graphical notification box if there are GraphQL errors in the response.
Motivation for the change:
Previously, notifications would only be displayed if the GraphQL response status code was
4xx/5xx
. With this change,2xx
responses which contain a GraphQL error response will also display notifications. This provides the user (or developer) more information about what went wrong with the request.How to manually test: