Closed andrewazores closed 4 months ago
Hi @andrewazores! Add at least one of the required labels to this PR
Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test
This PR/issue depends on:
@aali309 could you take a look at updating the unit tests related to the archived recordings views from your recent PR?
https://github.com/cryostatio/cryostat-web/actions/runs/8670862635/job/23779369922
Running yarn test:ci
locally should also show the same results.
Hmm nevermind, looks like it may have been just a merge issue.
Sorry, there was a merge issue, somehow it didn't merge properly from the PR and my first manual attempt was wrong. I think I have corrected it now and there are indeed unit test failures.
Also, "View in Grafana" on the Uploaded Archives view isn't working. I will help look into that one however, since it may be a similar issue to https://github.com/cryostatio/cryostat3/pull/324 on the server side. I tested it with that server side PR checked out as well and the other archived views have a working "View in Grafana", just not that one. I think it might be as simple as a JVM ID base64 encoding bug, or something like that.
Ok I will look into it also and update you.
/build_test
Test image available:
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1222-66848cb27b25300ce5f47a7c9b1af208a98fac20 bash smoketest.bash # then open http://localhost:8080
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Includes:
Depends on https://github.com/cryostatio/cryostat3/pull/294
Description of the change:
This change adds allows a match expression example to be copied to the clipboard...
Motivation for the change:
This change is helpful because users may want to copy the example for easier use...
How to manually test: