cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs

https://cryostat.io/

Other

10 stars 20 forks source link

fix(graphql): adjust GraphQL queries and models for updated server schema #1222

Closed andrewazores closed 4 months ago

andrewazores commented 6 months ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

[x] Read the contributing guidelines
[x] Linked a relevant issue which this PR resolves
[x] Linked any other relevant issues, PR's, or documentation, if any
[x] Resolved all conflicts, if any
[x] Rebased your branch PR on top of the latest upstream main branch
[x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
[x] Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Includes:

[x] #1219
[x] #1220
[x] #1221
[x] #1224
[x] #1227

Depends on https://github.com/cryostatio/cryostat3/pull/294

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
...

github-actions[bot] commented 6 months ago

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

github-actions[bot] commented 6 months ago

This PR/issue depends on:

cryostatio/cryostat3#294 By Dependent Issues (🤖). Happy coding!

andrewazores commented 4 months ago

@aali309 could you take a look at updating the unit tests related to the archived recordings views from your recent PR?

https://github.com/cryostatio/cryostat-web/actions/runs/8670862635/job/23779369922

Running yarn test:ci locally should also show the same results.

andrewazores commented 4 months ago

Hmm nevermind, looks like it may have been just a merge issue.

andrewazores commented 4 months ago

Sorry, there was a merge issue, somehow it didn't merge properly from the PR and my first manual attempt was wrong. I think I have corrected it now and there are indeed unit test failures.

andrewazores commented 4 months ago

Also, "View in Grafana" on the Uploaded Archives view isn't working. I will help look into that one however, since it may be a similar issue to https://github.com/cryostatio/cryostat3/pull/324 on the server side. I tested it with that server side PR checked out as well and the other archived views have a working "View in Grafana", just not that one. I think it might be as simple as a JVM ID base64 encoding bug, or something like that.

aali309 commented 4 months ago

Ok I will look into it also and update you.

andrewazores commented 4 months ago

/build_test

github-actions[bot] commented 4 months ago

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1222-66848cb27b25300ce5f47a7c9b1af208a98fac20 bash smoketest.bash # then open http://localhost:8080