cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs

https://cryostat.io/

Other

10 stars 20 forks source link

fix(topology): update for new GraphQL schema #1224

Closed andrewazores closed 5 months ago

andrewazores commented 6 months ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

[x] Read the contributing guidelines
[x] Linked a relevant issue which this PR resolves
[x] Linked any other relevant issues, PR's, or documentation, if any
[x] Resolved all conflicts, if any
[x] Rebased your branch PR on top of the latest upstream main branch
[x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
[x] Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Based on #1222 Depends on https://github.com/cryostatio/cryostat3/pull/315

Description of the change:

Adjustments for updated GraphQL schema in Cryostat 3.0.

Motivation for the change:

This re-enables the Topology view and all its features.

How to manually test:

Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
...

github-actions[bot] commented 6 months ago

This PR/issue depends on:

cryostatio/cryostat-web#1222
cryostatio/cryostat3#315 By Dependent Issues (🤖). Happy coding!

andrewazores commented 6 months ago

Ready for re-review @aali309 @mwangggg

mwangggg commented 5 months ago

the tests for AllTargetsArchivedRecordingsTable and AutomatedAnalysisCard still use the old schema: https://github.com/andrewazores/cryostat-web/blob/daa01bcf769bd0b733887f95a5ef05fc81a9c84e/src/test/Archives/AllTargetsArchivedRecordingsTable.test.tsx#L75-L85

aali309 commented 5 months ago

This PR looks good to me. Topology and Archive all work as expected.

mergify[bot] commented 5 months ago

⚠️ The sha of the head commit of this PR conflicts with #1227. Mergify cannot evaluate rules on this PR. ⚠️