cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

feat(certs): replace cert upload flow with cert listing #1240

Closed andrewazores closed 4 months ago

andrewazores commented 4 months ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to https://github.com/cryostatio/cryostat3/issues/306 Depends on https://github.com/cryostatio/cryostat3/pull/330

Description of the change:

Removes the JMX SSL cert upload modal, rewords some text associated with it, and adds a list of additional loaded certificate files to the Security card so that users can verify if the certificates required for their applications were properly supplied to the Cryostat server and if it should have loaded them to its truststore.


Without vertx-fib-demo.cer loaded:

image

image

With vertx-fib-demo.cer loaded:

image


Motivation for the change:

See #306

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh... -Ot
  2. The vertx-fib-demo.cer is here: https://github.com/andrewazores/vertx-fib-demo/blob/master/src/main/extras/app/resources/vertx-fib-demo.cer
  3. Try with and without that certificate placed within the cryostat3/truststore project directory. smoketest.bash creates a volume with that directory's contents and this becomes the additional truststore for the application within the smoketest.
github-actions[bot] commented 4 months ago

This PR/issue depends on: