cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

fix(graphql): query target nodes by targets' IDs rather than connectUrls #1245

Closed andrewazores closed 4 months ago

andrewazores commented 4 months ago

Welcome to Cryostat! šŸ‘‹

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1244 Depends on https://github.com/cryostatio/cryostat3/pull/342 (targetIds filter is added here)

Description of the change:

Updates GraphQL queries that act upon particular targets to do so by their IDs, rather than using the connectUrl as the node name filter.

Motivation for the change:

It is not guaranteed, and is not true for Cryostat Agent instances, that the discovery nodes' names are equal to their connection URLs. This fixes queries being unable to locate such nodes.

How to manually test:

  1. Combine with https://github.com/cryostatio/cryostat3/pull/342
  2. Select quarkus-test-agent target
  3. Go to Recordings, create a new recording, wait a few moments, then archive it
  4. Click the Archived recordings tab. The recording should appear in the table
github-actions[bot] commented 4 months ago

This PR/issue depends on: