search

cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

[Bug] JMC Agent Live Configuration tab does not update on notification #1247

Closed andrewazores closed 3 months ago

andrewazores commented 3 months ago 
          Nice, that worked! However now after inserting probes, switching to the Live Configuration tab shows an empty state. If I navigate away and back, or refresh the page, then I see the expected content:

image

image

This is probably just a web-client bug - it seems like the Live Configuration tab/table isn't reacting to the notification.

If it is the case that it's on the web-client side then I think this PR is good to go. Could you help check that out, ie. make sure it isn't some other notification that is missing or has a different category than the client expects etc.?

Originally posted by @andrewazores in https://github.com/cryostatio/cryostat3/issues/375#issuecomment-2067216133

andrewazores commented 3 months ago

https://github.com/cryostatio/cryostat-web/blob/89e2786769ee5bfde86ece129f09611c8fb55d28/src/app/Agent/AgentLiveProbes.tsx#L213

I think the connectUrl to targetId comparison is the likely culprit here. The table is supposed to react, but this condition or one of the others like it ignores it.