cryostatio / cryostat-web

Web front-end for Cryostat: Secure JDK Flight Recorder management for containerized JVMs
https://cryostat.io/
Other
10 stars 20 forks source link

fix(topology): delete action should be available for custom targets #1252

Closed tthvo closed 3 months ago

tthvo commented 3 months ago

Welcome to Cryostat! 👋

Before contributing, make sure you have:

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1251

Description of the change:

image

Motivation for the change:

See #1251

andrewazores commented 3 months ago

Looks like it worked - the deletion button appears again, and after clicking it I can see a request sent and success response from the server, and a "target lost" notification. However, the Topology view didn't update on the notification, so I had to navigate away and back to see the updated view state.

Seems like a separate bug, but worth noting. In testing https://github.com/cryostatio/cryostat3/pull/407 it looks like Agents deregistering also doesn't trigger Topology to update, so it could be a common root cause.

andrewazores commented 3 months ago

Bypassed the rule this time, but @tthvo please set up your GPG signature again with this email account :-)

tthvo commented 3 months ago

Ohh oops! That's odd. Somehow, the commit signature keep being not recognized again...I will check next time :D Thanks :)))