Closed tthvo closed 3 months ago
Looks like it worked - the deletion button appears again, and after clicking it I can see a request sent and success response from the server, and a "target lost" notification. However, the Topology view didn't update on the notification, so I had to navigate away and back to see the updated view state.
Seems like a separate bug, but worth noting. In testing https://github.com/cryostatio/cryostat3/pull/407 it looks like Agents deregistering also doesn't trigger Topology to update, so it could be a common root cause.
Bypassed the rule this time, but @tthvo please set up your GPG signature again with this email account :-)
Ohh oops! That's odd. Somehow, the commit signature keep being not recognized again...I will check next time :D Thanks :)))
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes: #1251
Description of the change:
allowList
andblockList
to be more flexible based on the tree element.REALM
annotation to ensure that only Custom Target is allowed to be deleted.Motivation for the change:
See #1251